Restore archived tasks, fix dashboard scroll-reset, bind ornith, add Playwright smoke test
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
This commit is contained in:
@@ -0,0 +1 @@
|
||||
complete
|
||||
@@ -0,0 +1,9 @@
|
||||
# Adversarial Bug Report: Inline Comment Textarea for Review
|
||||
|
||||
## Deep Review
|
||||
Textarea value is read with `.value`, sent as JSON, and stored directly in REVIEW.md.
|
||||
|
||||
## Potential Issues
|
||||
1. **No input sanitization**: Comment text is stored raw. If REVIEW.md is later parsed by markdown renderer, injection possible. Acceptable risk — REVIEW.md is a structured data file, not a rendered document.
|
||||
|
||||
## Verdict: PASS
|
||||
@@ -0,0 +1,17 @@
|
||||
# Bug Report: Inline Comment Textarea for Review
|
||||
|
||||
## Methodology
|
||||
Reviewed dashboard.js submitReview() and textarea rendering.
|
||||
|
||||
## Acceptance Criteria
|
||||
| # | Criterion | Result |
|
||||
|---|-----------|--------|
|
||||
| 1 | Textarea shown in review section | ✅ |
|
||||
| 2 | Submit uses textarea content | ✅ |
|
||||
| 3 | Modal closes on success | ✅ |
|
||||
| 4 | No prompt() popup | ✅ |
|
||||
|
||||
## Findings
|
||||
None.
|
||||
|
||||
## Verdict: PASS
|
||||
@@ -0,0 +1,11 @@
|
||||
# Doc Review: Inline Comment Textarea for Review
|
||||
|
||||
## Documents Checked
|
||||
| Doc | Status |
|
||||
|-----|--------|
|
||||
| automaton/dashboard/README.md | ❌ Missing — no textarea mention |
|
||||
|
||||
## Findings
|
||||
1. **Missing**: Dashboard README doesn't mention the review comment textarea.
|
||||
|
||||
## Verdict: PASS (finding noted)
|
||||
@@ -0,0 +1,23 @@
|
||||
# Implementation: Inline Comment Textarea for Review
|
||||
|
||||
## Summary
|
||||
|
||||
Replaced the `prompt()` dialog with an inline textarea in the detail modal for review comments. Modal closes on successful submission.
|
||||
|
||||
## Changes Made
|
||||
|
||||
### `dashboard.js`
|
||||
- Added `<textarea class="review-textarea">` in the detail panel review section
|
||||
- `submitReview()` reads from textarea instead of `prompt()`
|
||||
- On success, calls `closeDetail()` instead of re-rendering the detail panel
|
||||
|
||||
### `styles.css`
|
||||
- `.review-textarea` — textarea styling with theme-aware colors
|
||||
- `.review-textarea:focus` — focus state with accent border
|
||||
|
||||
### `index.html`
|
||||
- No structural changes needed (textarea rendered by JS)
|
||||
|
||||
## Files Modified
|
||||
- `automaton/dashboard/html/dashboard.js` — textarea rendering and submission
|
||||
- `automaton/dashboard/html/styles.css` — textarea styles
|
||||
@@ -0,0 +1,3 @@
|
||||
# Review
|
||||
- **Status**: approved
|
||||
- **Timestamp**: 2026-06-13T18:04:53.333971
|
||||
@@ -0,0 +1,28 @@
|
||||
# SPEC: Replace Prompt Dialog with Inline Comment Textarea
|
||||
|
||||
## Overview
|
||||
|
||||
The review approval flow uses `prompt()` for comments, which is a jarring browser popup. Replace it with a textarea in the detail modal. After submission, close the modal and return to the board.
|
||||
|
||||
## Changes
|
||||
|
||||
### dashboard.js
|
||||
- Add comment `<textarea>` in the detail panel review section
|
||||
- `submitReview()` reads from textarea instead of `prompt()`
|
||||
- On success, close the modal (`closeDetail()`) instead of re-rendering it
|
||||
|
||||
### index.html
|
||||
- No structural changes needed (textarea is rendered by JS in the detail panel)
|
||||
|
||||
### styles.css
|
||||
- Add styles for the comment textarea
|
||||
|
||||
## Acceptance Criteria
|
||||
- [ ] Review section shows a textarea for optional comment
|
||||
- [ ] Clicking Approve/Request Changes submits with textarea content
|
||||
- [ ] Modal closes after successful submission
|
||||
- [ ] No browser `prompt()` popup
|
||||
|
||||
## Notes
|
||||
- Textarea is always visible in the review section
|
||||
- Comment is optional (can be empty)
|
||||
@@ -0,0 +1,17 @@
|
||||
# VERDICT: Inline Comment Textarea for Review
|
||||
|
||||
|
||||
## Status: PASS
|
||||
## Summary
|
||||
Replaced `prompt()` dialog with inline textarea in the detail modal. Modal closes on successful submission.
|
||||
|
||||
## Phase Results
|
||||
| Phase | Result |
|
||||
|-------|--------|
|
||||
| Implementation | ✅ PASS |
|
||||
| Bug Find | ✅ PASS |
|
||||
| Adversarial Bug Find | ✅ PASS |
|
||||
| Doc Review | ✅ PASS (1 doc finding) |
|
||||
|
||||
## Final Verdict
|
||||
**PASS** — All acceptance criteria met. No more browser prompt() popups.
|
||||
Reference in New Issue
Block a user