Restore archived tasks, fix dashboard scroll-reset, bind ornith, add Playwright smoke test
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
This commit is contained in:
@@ -0,0 +1 @@
|
||||
complete
|
||||
@@ -0,0 +1 @@
|
||||
research:approved|2026-06-15T18:20:49.509508+00:00|user
|
||||
@@ -0,0 +1,21 @@
|
||||
# Adversarial Bug Report: hook-install-process
|
||||
|
||||
## Summary
|
||||
No critical issues. Two minor observations.
|
||||
|
||||
## Bugs Found
|
||||
|
||||
### Bug 1: upgrade.sh doesn't verify python3 is available (Low)
|
||||
- **Severity**: Low
|
||||
- **Location**: scripts/upgrade.sh line 26
|
||||
- **Description**: The script runs `python3 "$STATUS_SCRIPT" --upgrade` without checking if python3 exists. If python3 is not on PATH, the upgrade silently fails (due to `|| true`).
|
||||
- **Suggested Fix**: Add a python3 availability check at the start.
|
||||
|
||||
### Bug 2: Pre-commit hook doesn't handle bare repos (Low)
|
||||
- **Severity**: Low
|
||||
- **Location**: scripts/git-hooks/pre-commit
|
||||
- **Description**: If the project uses a bare repo or worktrees, `.git/hooks/` may not exist at the expected path.
|
||||
- **Suggested Fix**: Use `git rev-parse --git-dir` instead of assuming `.git/hooks/`.
|
||||
|
||||
## Score
|
||||
+5
|
||||
@@ -0,0 +1,10 @@
|
||||
# Bug Report: hook-install-process
|
||||
|
||||
## Summary
|
||||
No code bugs found. Process issue: the task was created after implementation was complete, which is a violation of the framework's own process. Otherwise, the changes are minimal and correct.
|
||||
|
||||
## Bugs Found
|
||||
None.
|
||||
|
||||
## Score
|
||||
+10
|
||||
@@ -0,0 +1,17 @@
|
||||
# Documentation Review: hook-install-process
|
||||
|
||||
## Summary
|
||||
Review of documentation for hook installation changes.
|
||||
|
||||
## Documentation Plan Compliance
|
||||
- [x] prompts/onboarding.md — Step 2c added with hook installation
|
||||
- [x] scripts/upgrade.sh — Hook installation logic with error handling
|
||||
- [x] scripts/install.sh — Post-install steps mention hook setup
|
||||
- [x] AGENTS.md — Repository layout includes git-hooks/ directory
|
||||
- [x] contracts/harness-integration.md — Pre-commit hook section with installation instructions
|
||||
|
||||
## Issues Found
|
||||
None — documentation is complete and consistent.
|
||||
|
||||
## Score
|
||||
+5
|
||||
@@ -0,0 +1,27 @@
|
||||
# Implementation: Hook Installation in Onboarding and Upgrade
|
||||
|
||||
## Changes
|
||||
|
||||
### 1. prompts/onboarding.md — Step 2c: Pre-Commit Hook Installation
|
||||
- Added Step 2c between VRAM config and Output sections
|
||||
- Checks for `.git/hooks/` directory
|
||||
- Creates symlink from `.git/hooks/pre-commit` to `~/.automaton/scripts/git-hooks/pre-commit`
|
||||
- Warns if existing hook is not our symlink
|
||||
- Verifies hook works with `status.py --can-edit`
|
||||
|
||||
### 2. scripts/upgrade.sh — Hook installation during upgrade
|
||||
- Added after the "Upgrade Complete" message
|
||||
- Detects `.git/hooks/` directory
|
||||
- If hook doesn't exist: creates symlink
|
||||
- If hook is already our symlink: reports "already linked"
|
||||
- If hook exists but is not our symlink: warns user, prints manual install command
|
||||
- If no `.git/hooks/`: prints note with manual install command
|
||||
|
||||
### 3. scripts/install.sh — Post-install next steps
|
||||
- Replaced single "Next step" with numbered list
|
||||
- Added hook installation as step 2
|
||||
- Added explanation of what the hook does
|
||||
|
||||
## Tests
|
||||
- All 200 tests pass
|
||||
- Shell syntax checks pass for install.sh and upgrade.sh
|
||||
@@ -0,0 +1,16 @@
|
||||
# Hook Installation in Onboarding and Upgrade
|
||||
|
||||
## Goal
|
||||
Add pre-commit hook installation to both the new-project onboarding process and the existing-project upgrade process, so enforcement is set up automatically.
|
||||
|
||||
## Requirements
|
||||
- Onboarding prompt includes a step to install the git pre-commit hook
|
||||
- upgrade.sh installs the hook during upgrade (with symlink detection)
|
||||
- install.sh mentions hook installation in post-install next steps
|
||||
|
||||
## Acceptance Criteria
|
||||
- [x] prompts/onboarding.md includes Step 2c for hook installation
|
||||
- [x] scripts/upgrade.sh installs hook and detects existing hooks
|
||||
- [x] scripts/install.sh mentions hook installation
|
||||
- [x] Shell scripts pass syntax check
|
||||
- [x] All 200 tests pass
|
||||
@@ -0,0 +1,20 @@
|
||||
# Verdict: hook-install-process
|
||||
|
||||
## Status: PASS
|
||||
**Completion Date**: 2026-06-15
|
||||
|
||||
## Summary
|
||||
Added pre-commit hook installation to onboarding and upgrade processes. Three files changed: onboarding prompt, upgrade.sh, and install.sh. All 200 tests pass, shell syntax checks pass.
|
||||
|
||||
## Findings
|
||||
- Onboarding prompt now includes Step 2c for git hook installation
|
||||
- upgrade.sh installs hook with symlink detection and conflict warning
|
||||
- install.sh mentions hook setup in post-install steps
|
||||
- Pre-commit enforcement working correctly (blocked a commit without a task)
|
||||
|
||||
## Remaining Issues
|
||||
- upgrade.sh doesn't verify python3 is available (low severity)
|
||||
- Pre-commit hook assumes `.git/hooks/` path (doesn't handle bare repos or worktrees)
|
||||
|
||||
## Score
|
||||
+10
|
||||
Reference in New Issue
Block a user