Restore archived tasks, fix dashboard scroll-reset, bind ornith, add Playwright smoke test
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
This commit is contained in:
@@ -0,0 +1 @@
|
||||
complete
|
||||
@@ -0,0 +1,15 @@
|
||||
# Adversarial Bug Report — harden-enforcement-layers
|
||||
|
||||
## Attack Vectors
|
||||
1. **Hook bypass**: Can a user bypass the pre-push hook?
|
||||
2. **Symlink attacks**: Does `install-hooks.sh` follow symlinks unsafely?
|
||||
3. **Command injection**: Does `register-guards.sh` have injection vectors in its Python inline script or pi install call?
|
||||
|
||||
## Findings
|
||||
- Pre-push hook can be bypassed with `--no-verify` (documented), but this is by design — it's a deterrent layer
|
||||
- `install-hooks.sh` uses `cp` not `ln -sf` — no symlink following risk
|
||||
- `register-guards.sh` passes `$OPENCODE_SOURCE` and `$PI_SOURCE` to Python/pi — these are hardcoded framework paths, not user input. Safe.
|
||||
- Python inline script uses `$OPENCODE_CONFIG` which could theoretically contain special chars, but this is a framework path from a controlled location
|
||||
|
||||
## Verdict
|
||||
No exploitable vulnerabilities found.
|
||||
@@ -0,0 +1,16 @@
|
||||
# Bug Report — harden-enforcement-layers
|
||||
|
||||
## Review Scope
|
||||
Pre-push hook, install-hooks.sh, register-guards.sh, prompt modifications, contract updates, install/update/upgrade scripts, system-prompt.md.
|
||||
|
||||
## Findings
|
||||
|
||||
### No Critical Bugs Found
|
||||
All scripts are syntactically correct (bash). The pre-push hook correctly calls `status.py --can-edit` with `--json` flag and blocks non-zero exit codes. The install-hooks.sh properly handles missing source files. The register-guards.sh correctly detects opencode config and pi binary.
|
||||
|
||||
### Minor Observations
|
||||
- `register-guards.sh` line 30 uses Python inline with `$OPENCODE_CONFIG` directly inside a Python string — this could break if the path contains special characters
|
||||
- `update.sh` hooks installation only runs if `git rev-parse` succeeds but doesn't check if the hook already exists (it checks `[ ! -f "$HOOK_DST" ]` which is safe)
|
||||
|
||||
## Verdict
|
||||
No blocking bugs. Ready for adversarial review.
|
||||
@@ -0,0 +1,13 @@
|
||||
# Doc Review — harden-enforcement-layers
|
||||
|
||||
## Documentation Reviewed
|
||||
- IMPLEMENTATION.md (task folder)
|
||||
- SPEC.md
|
||||
- contracts/harness-integration.md
|
||||
- New script headers (pre-push, install-hooks.sh, register-guards.sh)
|
||||
|
||||
## Findings
|
||||
Documentation is accurate and complete. The IMPLEMENTATION.md correctly covers all 14 changed files. The SPEC.md goal is fully met. Script headers have proper usage documentation.
|
||||
|
||||
## Verdict
|
||||
Documentation is satisfactory. No changes needed.
|
||||
@@ -0,0 +1,22 @@
|
||||
# Harden Enforcement Layers Implementation
|
||||
|
||||
## Summary
|
||||
Added pre-push hook, install-hooks.sh, plugin auto-registration, and prompt pre-edit checks to harden all enforcement layers.
|
||||
|
||||
## Changes
|
||||
|
||||
### New Files
|
||||
- `scripts/git-hooks/pre-push` — Blocks pushes when no task is in edit-allowed phase; catches `--no-verify` bypasses
|
||||
- `scripts/install-hooks.sh` — Installs pre-commit + pre-push hooks into a project
|
||||
- `scripts/register-guards.sh` — Auto-detects opencode/pi dev harnesses and registers guard plugins
|
||||
|
||||
### Modified Files
|
||||
- `contracts/harness-integration.md` — Updated to 4-layer enforcement model (added pre-push)
|
||||
- `prompts/doc_review.md` — Added pre-edit check section (MANDATORY)
|
||||
- `prompts/implement.md` — Added pre-edit check section (MANDATORY)
|
||||
- `prompts/orchestrate.md` — Added task creation section with clock-touch instructions
|
||||
- `scripts/install.sh` — Calls register-guards.sh post-install; updated hook installation docs
|
||||
- `scripts/update.sh` — Calls register-guards.sh; auto-installs hooks in current project
|
||||
- `scripts/upgrade.sh` — Installs both pre-commit and pre-push hooks (previously pre-commit only)
|
||||
- `system-prompt.md` — Added hook verification step and task-required-before-edits rule
|
||||
- `scripts/git-hooks/pre-commit` — Cleaned up error messages (removed bypass/upgrade instructions)
|
||||
@@ -0,0 +1 @@
|
||||
# Harden Enforcement Layers\n\nAdd pre-push hook, install-hooks.sh, plugin auto-registration, prompt pre-edit checks.
|
||||
@@ -0,0 +1,13 @@
|
||||
# Verdict — harden-enforcement-layers
|
||||
|
||||
## Status: PASS
|
||||
|
||||
## Summary
|
||||
All phases completed successfully:
|
||||
1. **Implement**: Pre-push hook, install-hooks.sh, register-guards.sh, prompt updates, script updates, contract updates
|
||||
2. **Bug Find**: No critical bugs found
|
||||
3. **Adversarial Bug Find**: No security vulnerabilities found
|
||||
4. **Doc Review**: Documentation accurate and complete
|
||||
|
||||
## Final Assessment
|
||||
Task satisfies all SPEC.md requirements. Marking complete.
|
||||
Reference in New Issue
Block a user