Restore archived tasks, fix dashboard scroll-reset, bind ornith, add Playwright smoke test
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
This commit is contained in:
@@ -0,0 +1 @@
|
||||
complete
|
||||
@@ -0,0 +1,24 @@
|
||||
# Implementation: Harden Dashboard Security and Fix Scripts
|
||||
|
||||
## Summary
|
||||
Closed security holes in the dashboard static file serving and tightened task name validation. Fixed `update.sh` to warn about uncommitted changes. Replaced placeholder URLs with the real Gitea repository URL. Added artifact integrity guidance.
|
||||
|
||||
## Files Changed
|
||||
- `automaton/dashboard/ui/app.py`
|
||||
- Replaced string-prefix path traversal check with robust `Path.relative_to()` resolution.
|
||||
- Tightened task name validation to allow only `[A-Za-z0-9_-]+`.
|
||||
- Added `import re`.
|
||||
- `tests/test_app.py` — added symlink path-traversal test and static-file happy-path test.
|
||||
- `scripts/update.sh` — added uncommitted-changes check before `git pull`.
|
||||
- `README.md` — replaced placeholder install URL with `http://10.37.0.86:3003/hermes/automaton`.
|
||||
- `scripts/install.sh` — replaced placeholder clone URL with `http://10.37.0.86:3003/hermes/automaton`.
|
||||
- `.rules.md` — added "Artifact Integrity" section with atomic-write guidance.
|
||||
|
||||
## Verification
|
||||
- `python -m pytest tests/` passes: **72 tests passed**.
|
||||
- `bash -n scripts/update.sh` passes.
|
||||
- `bash -n scripts/install.sh` passes.
|
||||
|
||||
## Decisions
|
||||
- Task names are restricted to kebab-case/alphanumeric to prevent filesystem traversal.
|
||||
- Symlinks escaping `html_dir` are rejected with 403.
|
||||
@@ -0,0 +1,4 @@
|
||||
# Review
|
||||
- **Status**: approved
|
||||
- **Timestamp**: 2026-06-14T09:59:34.838092
|
||||
- **Comment**:
|
||||
@@ -0,0 +1,25 @@
|
||||
# SPEC: Harden Dashboard Security and Fix Scripts
|
||||
|
||||
## Goal
|
||||
Close obvious security holes in the dashboard and fix script/documentation bugs identified in the audit.
|
||||
|
||||
## Requirements
|
||||
1. Fix path-traversal guard in `automaton/dashboard/ui/app.py`:
|
||||
- Replace string-prefix check with `Path.relative_to` resolution.
|
||||
2. Tighten task name validation in the review API.
|
||||
3. Add uncommitted-changes warning to `scripts/update.sh` before running `git pull`.
|
||||
4. Replace the placeholder repository URL in `README.md` and `scripts/install.sh` with `http://10.37.0.86:3003/hermes/automaton`.
|
||||
5. Add guidance on atomic artifact writes to `references/stop-hook-pattern.md` or `.rules.md`.
|
||||
|
||||
## Acceptance Criteria
|
||||
- [ ] Path-traversal check uses robust `Path` comparison.
|
||||
- [ ] Tests include path-traversal attempts.
|
||||
- [ ] `update.sh` aborts or warns when local uncommitted changes exist.
|
||||
- [ ] `README.md` and `install.sh` contain the real Gitea URL.
|
||||
|
||||
## Non-Goals
|
||||
- Adding authentication to the dashboard.
|
||||
- Rewriting scripts in another language.
|
||||
|
||||
## Stop Condition
|
||||
When all acceptance criteria are met, output "CONTRACT_MET".
|
||||
@@ -0,0 +1,20 @@
|
||||
# Verdict: Harden Dashboard Security and Fix Scripts
|
||||
|
||||
## Status: PASS
|
||||
**Completion Date**: 2026-06-14
|
||||
|
||||
## Summary
|
||||
Dashboard static file serving now uses a robust path containment check, task names are strictly validated, `update.sh` protects against overwriting local changes, and repository URLs point to the real Gitea instance.
|
||||
|
||||
## Findings
|
||||
- Path traversal check uses `Path.relative_to()`.
|
||||
- Task name regex rejects special characters and path separators.
|
||||
- `update.sh` aborts on uncommitted changes.
|
||||
- README and install script contain the real Gitea URL.
|
||||
- Atomic-write guidance added to `.rules.md`.
|
||||
|
||||
## Remaining Issues
|
||||
None.
|
||||
|
||||
## Score
|
||||
+10 PASS
|
||||
Reference in New Issue
Block a user