Restore archived tasks, fix dashboard scroll-reset, bind ornith, add Playwright smoke test
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
This commit is contained in:
@@ -0,0 +1,21 @@
|
||||
# Code Review: fix-vram-model-prefix-match
|
||||
|
||||
## Reviewed Files
|
||||
- `scripts/vram_detect.py` (`_lookup_model_context()`, `_KNOWN_MODEL_SUFFIXES`)
|
||||
|
||||
## Changes
|
||||
Replaced raw `startswith()` with three-tier matching: exact match, `:` separator (Ollama tags), and `-` separator with known instruction-tuning suffix whitelist.
|
||||
|
||||
## Analysis
|
||||
- **Correctness**: The three-tier approach correctly handles all test cases:
|
||||
- `deepseek-r1:7b` matches via `:` separator ✓
|
||||
- `llama-3.1-8b-instruct` matches via `-` + `instruct` suffix ✓
|
||||
- `phi-4-mini-instruct` rejected (`mini` not in suffixes) ✓
|
||||
- `gpt-4o-foo-unknown` rejected (`foo` not in suffixes) ✓
|
||||
- `phi-40` rejected (no separator) ✓
|
||||
- **Edge cases**: `gpt-4-turbo` is in the dict directly, so it matches via exact match (checked before `gpt-4` due to length-descending sort)
|
||||
- **Maintainability**: The suffix whitelist is explicit and easy to extend
|
||||
|
||||
## Verdict: PASS
|
||||
|
||||
The fix is well-structured, handles all edge cases correctly, and is properly tested.
|
||||
Reference in New Issue
Block a user