Restore archived tasks, fix dashboard scroll-reset, bind ornith, add Playwright smoke test
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
This commit is contained in:
@@ -0,0 +1 @@
|
||||
complete
|
||||
@@ -0,0 +1 @@
|
||||
# ADVERSARIAL_BUG_REPORT\n\nNo adversarial issues found.
|
||||
@@ -0,0 +1 @@
|
||||
# BUG_REPORT\n\nNo bugs found.
|
||||
@@ -0,0 +1 @@
|
||||
# DOC_REVIEW\n\nChanges are minimal and well-understood.
|
||||
@@ -0,0 +1,13 @@
|
||||
# IMPLEMENTATION.md — Fix Status Script Bugs
|
||||
|
||||
## Changes Made
|
||||
- `scripts/status.py:504-510`: Removed neutered target-phase artifact check (restored `pass` — analysis showed it's redundant with current-phase check at 525-531)
|
||||
- `scripts/status.py:1007,1061`: Removed dead double `continue` statements
|
||||
- `scripts/status.py:523`: Changed `cmd_approve` to use `_require_state` instead of `_read_state` for consistency
|
||||
- `scripts/status.py:1088-1095`: Added `cmd_list_states` function and `--list-states` CLI argument
|
||||
|
||||
## How It Works
|
||||
- `--list-states` prints all valid phases with approval requirements noted
|
||||
- Double continue dead code removed
|
||||
- cmd_approve rejects untracked tasks consistently
|
||||
- Target-phase check restored to `pass` (existing checks cover the cases correctly)
|
||||
@@ -0,0 +1,4 @@
|
||||
# Review
|
||||
- **Status**: approved
|
||||
- **Timestamp**: 2026-06-15T17:33:36.792602
|
||||
- **Comment**:
|
||||
@@ -0,0 +1,19 @@
|
||||
# Fix status.py Bugs
|
||||
|
||||
## Problem
|
||||
1. **Neutered target-phase artifact check** (status.py:488-492): loop body is `pass`, check never executes
|
||||
2. **Double `continue`** (status.py:1003-1004, 1057-1058): unreachable dead code
|
||||
3. **`cmd_approve` uses `_read_state`** (status.py:521): weaker than `_require_state`, silently handles untracked tasks
|
||||
4. **No `--list-states` command**: agents can't discover valid phases programmatically
|
||||
|
||||
## Fix
|
||||
1. Activate target-phase artifact check (remove `pass`, add actual validation)
|
||||
2. Remove duplicate `continue` statements
|
||||
3. Change `cmd_approve` to use `_require_state` for consistency
|
||||
4. Add `--list-states` argument that prints VALID_PHASES
|
||||
|
||||
## Verification
|
||||
- Target-phase artifact check blocks transitions when target's required artifact is missing
|
||||
- No dead code
|
||||
- `cmd_approve` rejects untracked tasks
|
||||
- `--list-states` prints all valid phases
|
||||
@@ -0,0 +1,3 @@
|
||||
VERDICT: PASS
|
||||
|
||||
All fixes verified. 206 tests pass.
|
||||
Reference in New Issue
Block a user