Restore archived tasks, fix dashboard scroll-reset, bind ornith, add Playwright smoke test
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
This commit is contained in:
@@ -0,0 +1,22 @@
|
||||
# Code Review: fix-stale-task-mtime-proxy
|
||||
|
||||
## Reviewed Files
|
||||
- `scripts/status.py` (`_get_edit_timestamp()`, `_touch_lastedit()`, `cmd_can_edit()`, `cmd_same_session()`, `cmd_touch()`, `NON_ARTIFACT_FILES`)
|
||||
|
||||
## Changes
|
||||
1. Added `.state.lastedit` file as the stale-task timer source
|
||||
2. `_touch_lastedit()` called on ALLOWED `--can-edit` responses
|
||||
3. `_get_edit_timestamp()` reads `.state.lastedit` with fallback to `.state` mtime
|
||||
4. Added staleness check to single-task `--can-edit --task` path
|
||||
5. `--touch` now touches `.state.lastedit` instead of `.state`
|
||||
|
||||
## Analysis
|
||||
- **Correctness**: Using `.state.lastedit` (touched on actual edit activity) is a better proxy for staleness than `.state` mtime (which only reflects phase transitions)
|
||||
- **Backward compatibility**: Falls back to `.state` mtime when `.state.lastedit` doesn't exist
|
||||
- **Non-artifact**: `.state.lastedit` correctly added to `NON_ARTIFACT_FILES` to avoid being treated as a phase artifact
|
||||
- **Single-task path**: Adding staleness check to `--can-edit --task` makes enforcement consistent across both code paths
|
||||
- **`--touch` command**: Updated to touch `.state.lastedit` — consistent with the new activity tracking model
|
||||
|
||||
## Verdict: PASS
|
||||
|
||||
The fix is well-structured, maintains backward compatibility, and correctly addresses the mtime proxy issue. Tests cover creation, staleness detection, and fallback behavior.
|
||||
Reference in New Issue
Block a user