Restore archived tasks, fix dashboard scroll-reset, bind ornith, add Playwright smoke test

- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top
  level (all <7 days old per the cleanup policy; premature bulk archive
  was fixed).
- **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds
  the board via innerHTML every 2s, destroying each column-body's
  scrollTop. Now snapshots column-body scrollTop + board.scrollLeft +
  view.scrollTop before rebuild and restores after (matched by
  PHASE_GROUPS index).
- **Dashboard UI additions** (pre-existing unstaged work): approval
  section cards, transition buttons, inline artifact editor (textarea for
  writing missing SPEC/VERDICT/etc from the detail modal).
- **Bind ornith as Implement model** — config.md: Model explicit to
  omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive
  autopilot already used ornith via opencode default; now explicit.
- **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg
  pointing at a pytest temp dir (test isolation leak). Rewired to point
  at ~/.automaton.
- **Fix plist-isolation test** — test asserted host plist doesn't exist,
  but a real install creates it. Now snapshots mtime before run, asserts
  unchanged after (only a write during the test counts as bleed).
- **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests:
  board renders tasks, column scroll survives auto-refresh tick.
  Verified the test fails without the scroll fix (scrollTop resets to 0).
  Skipped via importorskip when playwright is absent (main CI stays
  green).
- **Clarify SI loop scope in README** — new-project onboarding section
  documents the framework-scoped self-improvement loop and options
  (leave/pause/create project loop).
- **CHANGELOG** documents all changes including the known model-divergence
  gap (mde tasks marked complete but per-role model binding was never
  implemented).
This commit is contained in:
Lap Tran
2026-06-26 10:05:18 -04:00
parent fe43b9e1fc
commit bc7daf8590
666 changed files with 15994 additions and 69 deletions
+1
View File
@@ -0,0 +1 @@
complete
@@ -0,0 +1,2 @@
research:approved|2026-06-22T14:28:48.476535+00:00|user
code_review:approved|2026-06-22T14:36:53.472581+00:00|user
@@ -0,0 +1,12 @@
# Adversarial Bug Report: fix-dashboard-cors-origin
## Attack Vectors Tested
1. **Preflight OPTIONS request**: `do_OPTIONS()` returns 204 without CORS headers — browser will block cross-origin requests correctly
2. **Missing security headers on error responses**: `_send_error()` uses `SECURITY_HEADERS` — verified
3. **X-Frame-Options bypass**: `DENY` is the most restrictive value — no bypass
4. **MIME type confusion**: `X-Content-Type-Options: nosniff` prevents browsers from sniffing content type
## Findings
No bugs found. The security headers are correctly applied to all response types.
## Verdict: PASS
@@ -0,0 +1,9 @@
# Bug Report: fix-dashboard-cors-origin
## Scope
Reviewed `automaton/dashboard/ui/app.py` for security issues after CORS removal.
## Findings
No bugs found. Wildcard CORS headers removed. Security headers (`X-Content-Type-Options`, `X-Frame-Options`) correctly applied to all responses. `do_OPTIONS()` returns 204 without CORS headers.
## Verdict: PASS
@@ -0,0 +1,19 @@
# Code Review: fix-dashboard-cors-origin
## Reviewed Files
- `automaton/dashboard/ui/app.py` (`SECURITY_HEADERS`, `_send_json()`, `_send_error()`, `do_OPTIONS()`)
- `tests/test_app.py`
## Changes
Removed wildcard CORS headers (`Access-Control-Allow-Origin: *`), replaced with security headers (`X-Content-Type-Options: nosniff`, `X-Frame-Options: DENY`).
## Analysis
- **Security**: Removing wildcard CORS eliminates the risk of cross-origin attacks from malicious local web pages
- **Single-origin app**: The dashboard is a local web app served from a single origin — CORS is unnecessary
- **Security headers**: `X-Content-Type-Options: nosniff` prevents MIME type sniffing, `X-Frame-Options: DENY` prevents clickjacking
- **OPTIONS handler**: `do_OPTIONS()` still returns 204 No Content (for preflight requests) but without CORS headers
- **Tests**: Test assertions correctly verify absence of CORS headers and presence of security headers
## Verdict: PASS
The fix eliminates a security vulnerability while adding useful hardening headers. Tests are properly updated.
@@ -0,0 +1,13 @@
# Doc Review: fix-dashboard-cors-origin
## Documentation Impact
No external documentation changes needed. The CHANGELOG.md previously recorded "Added CORS headers" — the CHANGELOG should note their removal for this fix.
## Checklist
- [x] No new commands or flags introduced
- [x] AGENTS.md unchanged — no CORS references in framework docs
- [x] README.md unchanged — no CORS references
- [x] CHANGELOG.md will be updated to note CORS removal and security headers added
- [x] `harden-dashboard-security` task history preserved (not modified — it's a historical record)
## Verdict: PASS
@@ -0,0 +1,18 @@
# Implementation: fix-dashboard-cors-origin
## Bug
Dashboard's `app.py` set `Access-Control-Allow-Origin: *` (wildcard CORS) on all responses via `CORS_HEADERS`. Since the dashboard is a local single-origin app, this wildcard CORS header is unnecessary and poses a security risk — any malicious webpage on the machine could make requests to the dashboard API.
## Fix
1. Removed `CORS_HEADERS` dictionary (which contained `Access-Control-Allow-Origin: *` and `Access-Control-Allow-Methods`)
2. Added `SECURITY_HEADERS` with `X-Content-Type-Options: nosniff` and `X-Frame-Options: DENY`
3. Updated `_send_json()`, `_send_error()`, and `do_OPTIONS()` to use `SECURITY_HEADERS` instead of `CORS_HEADERS`
4. `do_OPTIONS()` no longer returns `Access-Control-Allow-*` headers — it simply returns 204 No Content
## Files Changed
- `automaton/dashboard/ui/app.py`: Replaced `CORS_HEADERS` with `SECURITY_HEADERS`, updated all response methods
- `tests/test_app.py`: Updated CORS-related tests to assert NO `Access-Control-Allow-Origin` header is present, and that security headers are sent
## Tests
- `test_app.py` tests updated to verify security headers (`X-Content-Type-Options`, `X-Frame-Options`) and absence of CORS headers
- All 249 tests pass
+17
View File
@@ -0,0 +1,17 @@
# Spec: fix-dashboard-cors-origin
## Problem
`automaton/dashboard/ui/app.py:40-44` sets `Access-Control-Allow-Origin: *` on all responses, including POST and PUT endpoints. Any website open in the user's browser can send cross-origin requests to `localhost:8080`, allowing silent modification of task reviews and config.
## Fix
Remove the wildcard CORS origin. The dashboard is a local single-origin app — CORS headers are unnecessary. Either:
1. Remove `CORS_HEADERS` entirely and stop sending them, OR
2. Set `Access-Control-Allow-Origin` to `http://localhost:{port}` only
Option 1 is simpler and safer. The dashboard serves both the HTML and the API from the same origin, so CORS is not needed.
## Acceptance Criteria
- No `Access-Control-Allow-Origin: *` header in responses
- Cross-origin requests from other websites are blocked by the browser
- Same-origin dashboard HTML can still fetch the API (no CORS needed)
- Existing CORS tests in `test_app.py` updated to reflect the change
@@ -0,0 +1,13 @@
# Verdict: fix-dashboard-cors-origin
## Status: PASS
## Summary
Removed wildcard CORS headers (`Access-Control-Allow-Origin: *`) from dashboard API responses. Replaced with security headers (`X-Content-Type-Options: nosniff`, `X-Frame-Options: DENY`). Tests updated to verify absence of CORS headers and presence of security headers.
## Artifacts
- IMPLEMENTATION.md: Complete
- CODE_REVIEW.md: PASS
- BUG_REPORT.md: No bugs found
- ADVERSARIAL_BUG_REPORT.md: No bugs found
- DOC_REVIEW.md: PASS