Restore archived tasks, fix dashboard scroll-reset, bind ornith, add Playwright smoke test
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
This commit is contained in:
Lap Tran
@@ -0,0 +1 @@
|
||||
complete
|
||||
@@ -0,0 +1,2 @@
|
||||
research:approved|2026-06-22T13:56:13.680386+00:00|user
|
||||
code_review:approved|2026-06-22T14:06:36.841131+00:00|user
|
||||
@@ -0,0 +1,18 @@
|
||||
# Adversarial Bug Report: fix-cat3-audit-paths
|
||||
|
||||
## Summary
|
||||
Adversarial review of the Category 3 audit path fix. No additional bugs found.
|
||||
|
||||
## Bugs Found
|
||||
No bugs found.
|
||||
|
||||
## Analysis
|
||||
- **Race conditions**: `_audit_category3` reads git diff state at a point in time. No concurrent modification risk since it's a read-only audit.
|
||||
- **Path traversal**: The check uses `Path(changed_file).parts` which splits on path separators — no traversal bypass possible.
|
||||
- **Edge case — nested subtasks**: `.automaton/tasks/parent/subtasks/child/file` has `parts[2]` = `parent`, which is in `task_names` (subtasks are listed as `parent` in `_all_task_dirs`). Correctly excluded.
|
||||
- **Edge case — empty task_names**: If `tasks` is empty, `task_names` is empty, and no file matches — all files flagged as unauthorized. This is correct behavior (no tasks = no authorized edits).
|
||||
|
||||
## Score
|
||||
0
|
||||
|
||||
ADVERSARIAL_BUG_FIND_COMPLETE
|
||||
@@ -0,0 +1,15 @@
|
||||
# Bug Report: fix-cat3-audit-paths
|
||||
|
||||
## Summary
|
||||
The fix correctly handles both framework mode and regular project mode path prefixes in the Category 3 audit.
|
||||
|
||||
## Bugs Found
|
||||
No bugs found.
|
||||
|
||||
## Verification
|
||||
- The path check at status.py:718-732 correctly handles both `tasks/mytask/...` (framework) and `.automaton/tasks/mytask/...` (regular project).
|
||||
- Subtask paths (`.automaton/tasks/parent/subtasks/child/...`) have `parts[2]` = `parent`, which is in `task_names` — correctly excluded.
|
||||
- Test `TestCat3AuditRegularProjectPaths` passes.
|
||||
|
||||
## Score
|
||||
0
|
||||
@@ -0,0 +1,12 @@
|
||||
# Code Review: fix-cat3-audit-paths
|
||||
|
||||
## Summary
|
||||
Fix is minimal and correct. Adds a second path check for `.automaton/tasks/` prefix to handle regular projects.
|
||||
|
||||
## Findings
|
||||
- **Correctness**: The fix correctly handles both framework mode (`tasks/...`) and regular project mode (`.automaton/tasks/...`). The `if not is_in_task_folder` guard before the second check avoids redundant evaluation.
|
||||
- **Edge cases**: Subtask paths (`.automaton/tasks/parent/subtasks/child/...`) would have `parts[2]` = `parent`, which is in `task_names` (since `_all_task_dirs` includes subtasks with their parent name). This is correct — subtask files are also excluded from unauthorized.
|
||||
- **No regressions**: Existing framework-mode audit tests still pass.
|
||||
|
||||
## Verdict
|
||||
APPROVED — no issues found.
|
||||
@@ -0,0 +1,11 @@
|
||||
# Doc Review: fix-cat3-audit-paths
|
||||
|
||||
## Summary
|
||||
No documentation updates needed. The Category 3 audit is an internal enforcement mechanism not documented in user-facing docs.
|
||||
|
||||
## Findings
|
||||
- No references to the Cat 3 audit path logic exist in README.md, AGENTS.md, or other docs.
|
||||
- The fix is internal to `status.py` and does not change any user-facing API.
|
||||
|
||||
## Verdict
|
||||
No doc changes required.
|
||||
@@ -0,0 +1,7 @@
|
||||
# Implementation: fix-cat3-audit-paths
|
||||
|
||||
## Changes
|
||||
- **scripts/status.py** `_audit_category3()` (~line 696): Added a second path check for regular projects. Files matching `.automaton/tasks/{task_name}/...` are now correctly recognized as inside task folders, in addition to the existing `tasks/{task_name}/...` check for framework mode.
|
||||
|
||||
## Test
|
||||
- `tests/test_status.py::TestCat3AuditRegularProjectPaths::test_regular_project_task_path_not_flagged` — verifies that changes inside `.automaton/tasks/` in a regular project are not flagged as unauthorized.
|
||||
@@ -0,0 +1,14 @@
|
||||
# Spec: fix-cat3-audit-paths
|
||||
|
||||
## Problem
|
||||
`_audit_category3()` in `scripts/status.py:696` checks if changed files are inside task folders using `parts[0] == "tasks"`. This only works for the framework directory (`~/.automaton/`) where git paths are `tasks/mytask/...`. For regular projects, task files have git paths like `.automaton/tasks/mytask/SPEC.md`, where `parts[0]` is `.automaton`, not `tasks`. All task-folder changes are incorrectly flagged as unauthorized.
|
||||
|
||||
## Fix
|
||||
Update the path check at `scripts/status.py:696` to handle both cases:
|
||||
- Framework mode: `parts[0] == "tasks" and parts[1] in task_names`
|
||||
- Regular project: `len(parts) >= 3 and parts[0] == ".automaton" and parts[1] == "tasks" and parts[2] in task_names`
|
||||
|
||||
## Acceptance Criteria
|
||||
- `--audit` on a regular project with changes inside `.automaton/tasks/` does NOT flag them as unauthorized
|
||||
- `--audit` on the framework directory still works correctly
|
||||
- Add a test in `tests/test_status.py` covering the regular-project path check
|
||||
@@ -0,0 +1,26 @@
|
||||
# Verdict: fix-cat3-audit-paths
|
||||
|
||||
## Status: PASS
|
||||
**Completion Date**: 2026-06-22
|
||||
|
||||
## Summary
|
||||
The fix correctly handles both framework mode and regular project mode path prefixes in the Category 3 audit. All tests pass.
|
||||
|
||||
## Findings
|
||||
- The fix adds a second path check for `.automaton/tasks/{task_name}/...` alongside the existing `tasks/{task_name}/...` check.
|
||||
- Bug Finder found no bugs. Adversarial Bug Finder found no bugs.
|
||||
- No contradictions between the two reports.
|
||||
- Test coverage added: `TestCat3AuditRegularProjectPaths`.
|
||||
- All 242 tests pass.
|
||||
|
||||
## Tasks for Review / Tie-Breaks
|
||||
None.
|
||||
|
||||
## Remaining Issues
|
||||
None.
|
||||
|
||||
## Score
|
||||
+10 (PASS)
|
||||
|
||||
## Reviewer Comments
|
||||
|
||||
Reference in New Issue
Block a user