Restore archived tasks, fix dashboard scroll-reset, bind ornith, add Playwright smoke test
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
This commit is contained in:
@@ -0,0 +1,25 @@
|
||||
# Code Review: add-outputs-retention
|
||||
|
||||
## SPEC coverage
|
||||
|
||||
| Requirement | Status |
|
||||
|-------------|--------|
|
||||
| R1 — `_get_retention` helper from `outputs.retention` | ✓ |
|
||||
| R2 — GC executes on every tick (post-write) | ✓ step 10.5 inside `_loop_lock` |
|
||||
| R3 — Retention = 0 means no GC | ✓ `if retention <= 0: return` |
|
||||
| R4 — GC failure doesn't crash tick | ✓ OSError caught → WARNING log + swallow |
|
||||
| R5 — No new pip deps | ✓ stdlib only |
|
||||
|
||||
## Cross-script impact
|
||||
|
||||
- `scripts/loop-runner.py`: pure addition; no existing function changed.
|
||||
- `templates/loops/self-improvement/loop.json`: new `outputs.retention: 20` field.
|
||||
- `scripts/status.py`: no changes needed (create-loop template provides the default; runner reads, not status.py).
|
||||
|
||||
## Off-by-one fix
|
||||
|
||||
GC formula was `cutoff = max_seen - retention` (kept retention+1 groups). Found during test execution when `test_gc_keeps_recent_deletes_old` showed 21 remaining instead of 20. Fixed to `cutoff = max_seen - retention + 1`. Good test coverage.
|
||||
|
||||
## Verdict
|
||||
|
||||
PASS — proceed to bug_find.
|
||||
Reference in New Issue
Block a user