Restore archived tasks, fix dashboard scroll-reset, bind ornith, add Playwright smoke test
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
This commit is contained in:
@@ -0,0 +1 @@
|
||||
complete
|
||||
@@ -0,0 +1,14 @@
|
||||
# Adversarial Bug Report — actionable-phase-guidance
|
||||
|
||||
## Attack Vectors
|
||||
1. **Empty state**: What happens for an unknown/unexpected state value?
|
||||
2. **HTML injection**: Could guidance text contain user-controlled content that escapes sanitization?
|
||||
3. **Empty guidance**: Does the frontend handle missing/incomplete guidance gracefully?
|
||||
|
||||
## Findings
|
||||
- Unknown states fall through to a generic return — safe, no crash
|
||||
- Guidance text is static (no user content), so injection is not a concern
|
||||
- Frontend checks `task.phase_guidance` truthiness before rendering the guidance section — safe
|
||||
|
||||
## Verdict
|
||||
No vulnerabilities found. The implementation is defensive against all checked attack vectors.
|
||||
@@ -0,0 +1,16 @@
|
||||
# Bug Report — actionable-phase-guidance
|
||||
|
||||
## Review Scope
|
||||
Phase guidance feature across task.py, app.py, dashboard.js, styles.css.
|
||||
|
||||
## Findings
|
||||
|
||||
### No Critical Bugs Found
|
||||
The implementation is clean and well-structured. The phase guidance property covers all 12 states with actionable text. The frontend renders guidance conditionally. All three layers (model, API, UI) are properly wired.
|
||||
|
||||
### Minor Observations
|
||||
- Some guidance messages reference `{self.name}` without `--project` flag, which may misbehave when run outside the framework project
|
||||
- Guidance for BLOCKED state delegates to `unblock_instructions` which is populated only for specific block conditions
|
||||
|
||||
## Verdict
|
||||
No blocking bugs. Ready for adversarial review.
|
||||
@@ -0,0 +1,13 @@
|
||||
# Doc Review — actionable-phase-guidance
|
||||
|
||||
## Documentation Reviewed
|
||||
- IMPLEMENTATION.md (task folder)
|
||||
- SPEC.md
|
||||
- task.py docstrings and comments
|
||||
- dashboard.js comments
|
||||
|
||||
## Findings
|
||||
Documentation is accurate and complete. The IMPLEMENTATION.md correctly enumerates all changed files. The SPEC.md goal ("Add actionable next-step guidance to all dashboard phases") is fully met. No documentation gaps found.
|
||||
|
||||
## Verdict
|
||||
Documentation is satisfactory. No changes needed.
|
||||
@@ -0,0 +1,22 @@
|
||||
# Phase Guidance Implementation
|
||||
|
||||
## Summary
|
||||
Added actionable next-step guidance to all dashboard phases across the full stack.
|
||||
|
||||
## Changes
|
||||
|
||||
### automaton/dashboard/core/task.py
|
||||
- Added `phase_guidance` property to `Task` dataclass providing per-phase actionable guidance text
|
||||
- Added `blocker` property for identifying what blocks task progression
|
||||
- Added `required_artifact_name` and `next_phase_name` helper properties
|
||||
|
||||
### automaton/dashboard/ui/app.py
|
||||
- Exposed `phase_guidance`, `blocker`, `required_artifact_name`, `next_phase_name` in the `/api/tasks` JSON response
|
||||
|
||||
### automaton/dashboard/html/dashboard.js
|
||||
- Added "What's Next" section in the detail modal rendering `phase_guidance`
|
||||
- Added "What's Blocking" section rendering `blocker`
|
||||
- Added status reason display on task cards
|
||||
|
||||
### automaton/dashboard/html/styles.css
|
||||
- Added `.detail-guidance`, `.detail-blocker`, `.detail-status-reason` CSS classes
|
||||
@@ -0,0 +1 @@
|
||||
# Phase Guidance\n\nAdd actionable next-step guidance to all dashboard phases.
|
||||
@@ -0,0 +1,13 @@
|
||||
# Verdict — actionable-phase-guidance
|
||||
|
||||
## Status: PASS
|
||||
|
||||
## Summary
|
||||
All phases completed successfully:
|
||||
1. **Implement**: Phase guidance added across all dashboard layers (model, API, UI)
|
||||
2. **Bug Find**: No critical bugs found
|
||||
3. **Adversarial Bug Find**: No security vulnerabilities found
|
||||
4. **Doc Review**: Documentation accurate and complete
|
||||
|
||||
## Final Assessment
|
||||
Task satisfies all SPEC.md requirements. Marking complete.
|
||||
Reference in New Issue
Block a user