Fix 10 audit bugs: path prefix matching, verdict parsing, CORS, stale-task detection, phase mapping
CI / build (push) Has been cancelled
CI / build (push) Has been cancelled
Batch 1 (High severity): - Bug 1: --audit cat3 now checks .automaton/tasks/ paths - Bug 4: Verdict PASS/FAIL uses structured ## Status: line parsing - Bug 5: register-guards.sh checks .json/.jsonc, writes plugin key, strips comments - Bug 7: --can-edit/--scope-check path prefix uses os.sep boundary Batch 2 (Medium/Low severity): - Bug 2: migrate-project.sh find command parentheses for -prune binding - Bug 3: vram_detect model prefix matching with known-suffix whitelist - Bug 6: dashboard reads .state file before artifact heuristic fallback - Bug 8: removed wildcard CORS, added security headers (nosniff, DENY) - Bug 9: stale-task detection uses .state.lastedit instead of .state mtime - Bug 10: TEST_PLAN.md maps to test_design (was implement) 249 tests pass (up from 235). All 10 tasks driven through full workflow to completion.
This commit is contained in:
@@ -0,0 +1,14 @@
|
||||
# Spec: fix-cat3-audit-paths
|
||||
|
||||
## Problem
|
||||
`_audit_category3()` in `scripts/status.py:696` checks if changed files are inside task folders using `parts[0] == "tasks"`. This only works for the framework directory (`~/.automaton/`) where git paths are `tasks/mytask/...`. For regular projects, task files have git paths like `.automaton/tasks/mytask/SPEC.md`, where `parts[0]` is `.automaton`, not `tasks`. All task-folder changes are incorrectly flagged as unauthorized.
|
||||
|
||||
## Fix
|
||||
Update the path check at `scripts/status.py:696` to handle both cases:
|
||||
- Framework mode: `parts[0] == "tasks" and parts[1] in task_names`
|
||||
- Regular project: `len(parts) >= 3 and parts[0] == ".automaton" and parts[1] == "tasks" and parts[2] in task_names`
|
||||
|
||||
## Acceptance Criteria
|
||||
- `--audit` on a regular project with changes inside `.automaton/tasks/` does NOT flag them as unauthorized
|
||||
- `--audit` on the framework directory still works correctly
|
||||
- Add a test in `tests/test_status.py` covering the regular-project path check
|
||||
Reference in New Issue
Block a user