Archive completed tasks, add cleanup commands, self-documenting dashboard UI
CI / build (push) Has been cancelled
CI / build (push) Has been cancelled
- Archive 79 completed framework-dev tasks from tasks/ -> tasks/complete/ - status.py: add --cleanup-done and --install-cleanup-schedule commands - Add scripts/automaton-cleanup.sh for periodic task archiving - Dashboard: rename 'Background' tab -> 'Agent', 'Cleanup' agent -> 'Completed Task Archiver', remove redundant group headers and pill badges, dim inactive agent placeholders - .rules.md: add Self-Documenting UI Names rule - New tests: test_cleanup_done.py, expanded test_app.py and test_task.py
This commit is contained in:
@@ -1 +0,0 @@
|
||||
complete
|
||||
@@ -1,9 +0,0 @@
|
||||
# Adversarial Bug Report: Inline Comment Textarea for Review
|
||||
|
||||
## Deep Review
|
||||
Textarea value is read with `.value`, sent as JSON, and stored directly in REVIEW.md.
|
||||
|
||||
## Potential Issues
|
||||
1. **No input sanitization**: Comment text is stored raw. If REVIEW.md is later parsed by markdown renderer, injection possible. Acceptable risk — REVIEW.md is a structured data file, not a rendered document.
|
||||
|
||||
## Verdict: PASS
|
||||
@@ -1,17 +0,0 @@
|
||||
# Bug Report: Inline Comment Textarea for Review
|
||||
|
||||
## Methodology
|
||||
Reviewed dashboard.js submitReview() and textarea rendering.
|
||||
|
||||
## Acceptance Criteria
|
||||
| # | Criterion | Result |
|
||||
|---|-----------|--------|
|
||||
| 1 | Textarea shown in review section | ✅ |
|
||||
| 2 | Submit uses textarea content | ✅ |
|
||||
| 3 | Modal closes on success | ✅ |
|
||||
| 4 | No prompt() popup | ✅ |
|
||||
|
||||
## Findings
|
||||
None.
|
||||
|
||||
## Verdict: PASS
|
||||
@@ -1,11 +0,0 @@
|
||||
# Doc Review: Inline Comment Textarea for Review
|
||||
|
||||
## Documents Checked
|
||||
| Doc | Status |
|
||||
|-----|--------|
|
||||
| automaton/dashboard/README.md | ❌ Missing — no textarea mention |
|
||||
|
||||
## Findings
|
||||
1. **Missing**: Dashboard README doesn't mention the review comment textarea.
|
||||
|
||||
## Verdict: PASS (finding noted)
|
||||
@@ -1,23 +0,0 @@
|
||||
# Implementation: Inline Comment Textarea for Review
|
||||
|
||||
## Summary
|
||||
|
||||
Replaced the `prompt()` dialog with an inline textarea in the detail modal for review comments. Modal closes on successful submission.
|
||||
|
||||
## Changes Made
|
||||
|
||||
### `dashboard.js`
|
||||
- Added `<textarea class="review-textarea">` in the detail panel review section
|
||||
- `submitReview()` reads from textarea instead of `prompt()`
|
||||
- On success, calls `closeDetail()` instead of re-rendering the detail panel
|
||||
|
||||
### `styles.css`
|
||||
- `.review-textarea` — textarea styling with theme-aware colors
|
||||
- `.review-textarea:focus` — focus state with accent border
|
||||
|
||||
### `index.html`
|
||||
- No structural changes needed (textarea rendered by JS)
|
||||
|
||||
## Files Modified
|
||||
- `automaton/dashboard/html/dashboard.js` — textarea rendering and submission
|
||||
- `automaton/dashboard/html/styles.css` — textarea styles
|
||||
@@ -1,3 +0,0 @@
|
||||
# Review
|
||||
- **Status**: approved
|
||||
- **Timestamp**: 2026-06-13T18:04:53.333971
|
||||
@@ -1,28 +0,0 @@
|
||||
# SPEC: Replace Prompt Dialog with Inline Comment Textarea
|
||||
|
||||
## Overview
|
||||
|
||||
The review approval flow uses `prompt()` for comments, which is a jarring browser popup. Replace it with a textarea in the detail modal. After submission, close the modal and return to the board.
|
||||
|
||||
## Changes
|
||||
|
||||
### dashboard.js
|
||||
- Add comment `<textarea>` in the detail panel review section
|
||||
- `submitReview()` reads from textarea instead of `prompt()`
|
||||
- On success, close the modal (`closeDetail()`) instead of re-rendering it
|
||||
|
||||
### index.html
|
||||
- No structural changes needed (textarea is rendered by JS in the detail panel)
|
||||
|
||||
### styles.css
|
||||
- Add styles for the comment textarea
|
||||
|
||||
## Acceptance Criteria
|
||||
- [ ] Review section shows a textarea for optional comment
|
||||
- [ ] Clicking Approve/Request Changes submits with textarea content
|
||||
- [ ] Modal closes after successful submission
|
||||
- [ ] No browser `prompt()` popup
|
||||
|
||||
## Notes
|
||||
- Textarea is always visible in the review section
|
||||
- Comment is optional (can be empty)
|
||||
@@ -1,17 +0,0 @@
|
||||
# VERDICT: Inline Comment Textarea for Review
|
||||
|
||||
|
||||
## Status: PASS
|
||||
## Summary
|
||||
Replaced `prompt()` dialog with inline textarea in the detail modal. Modal closes on successful submission.
|
||||
|
||||
## Phase Results
|
||||
| Phase | Result |
|
||||
|-------|--------|
|
||||
| Implementation | ✅ PASS |
|
||||
| Bug Find | ✅ PASS |
|
||||
| Adversarial Bug Find | ✅ PASS |
|
||||
| Doc Review | ✅ PASS (1 doc finding) |
|
||||
|
||||
## Final Verdict
|
||||
**PASS** — All acceptance criteria met. No more browser prompt() popups.
|
||||
Reference in New Issue
Block a user