Archive completed tasks, add cleanup commands, self-documenting dashboard UI

- Archive 79 completed framework-dev tasks from tasks/ -> tasks/complete/ - status.py: add --cleanup-done and --install-cleanup-schedule commands - Add scripts/automaton-cleanup.sh for periodic task archiving - Dashboard: rename 'Background' tab -> 'Agent', 'Cleanup' agent -> 'Completed Task Archiver', remove redundant group headers and pill badges, dim inactive agent placeholders - .rules.md: add Self-Documenting UI Names rule - New tests: test_cleanup_done.py, expanded test_app.py and test_task.py
2026-06-24 22:43:33 -04:00
parent e13513faaa
commit 4a2301b077
572 changed files with 856 additions and 101 deletions
@@ -0,0 +1 @@
+complete
@@ -0,0 +1,2 @@
+research:approved|2026-06-22T14:28:48.368369+00:00|user
+code_review:approved|2026-06-22T14:36:53.367222+00:00|user
@@ -0,0 +1,12 @@
+# Adversarial Bug Report: fix-dashboard-read-state
+
+## Attack Vectors Tested
+1. **Corrupted .state file**: Empty file or garbage content — `_state_string_to_task_state()` returns `None`, falls back to artifact heuristic
+2. **Unknown phase in .state**: Returns `None`, falls back to artifacts — correct
+3. **Sub-state with multiple colons**: `code_review:awaiting_approval:extra` — `split(":")[0]` gives `code_review` — correct
+4. **Race condition**: `.state` file modified between read and use — not a concern for dashboard display (eventual consistency)
+
+## Findings
+No bugs found.
+
+## Verdict: PASS
@@ -0,0 +1,9 @@
+# Bug Report: fix-dashboard-read-state
+
+## Scope
+Reviewed `automaton/dashboard/core/task.py` `_state_string_to_task_state()` and `determine_task_state()`.
+
+## Findings
+No bugs found. The `.state` file is correctly read and takes precedence over artifact heuristic. Sub-state handling (split on `:`) is correct. Fallback to artifacts for tasks without `.state` is maintained.
+
+## Verdict: PASS
@@ -0,0 +1,17 @@
+# Code Review: fix-dashboard-read-state
+
+## Reviewed Files
+- `automaton/dashboard/core/task.py` (`_state_string_to_task_state()`, `determine_task_state()`)
+
+## Changes
+Added `_state_string_to_task_state()` helper and modified `determine_task_state()` to read `.state` file before falling back to artifact heuristic.
+
+## Analysis
+- **Correctness**: `.state` file is the source of truth per v2.0 framework design, so it should take precedence
+- **Sub-state handling**: `_state_string_to_task_state()` correctly splits on `:` to extract base phase (e.g. `code_review:awaiting_approval` → `CODE_REVIEW`)
+- **Fallback**: Tasks without `.state` files still work via artifact heuristic (backward compatible)
+- **Null safety**: Returns `None` for unrecognized phase strings, which `determine_task_state()` handles by falling through to artifacts
+
+## Verdict: PASS
+
+The fix correctly prioritizes the `.state` file as source of truth while maintaining backward compatibility.
@@ -0,0 +1,12 @@
+# Doc Review: fix-dashboard-read-state
+
+## Documentation Impact
+No documentation changes needed. The fix is internal to the dashboard's state inference logic.
+
+## Checklist
+- [x] No new API endpoints or UI changes
+- [x] AGENTS.md unchanged — dashboard section still accurate
+- [x] README.md dashboard section unchanged
+- [x] CHANGELOG.md will be updated for the release
+
+## Verdict: PASS
@@ -0,0 +1,15 @@
+# Implementation: fix-dashboard-read-state
+
+## Bug
+Dashboard's `determine_task_state()` in `task.py` inferred task phase from artifact filenames only, ignoring the `.state` file. This caused the dashboard to show incorrect states when the `.state` file (source of truth) disagreed with the artifact heuristic.
+
+## Fix
+1. Added `_state_string_to_task_state()` helper function that maps state machine phase strings (e.g. `"implement"`, `"code_review:awaiting_approval"`) to `TaskState` enum values. Handles sub-states by splitting on `":"` and using the base phase.
+2. Modified `determine_task_state()` to read the `.state` file first. If `.state` exists and maps to a valid `TaskState`, that takes precedence. The artifact heuristic is now a fallback for tasks without `.state` files.
+
+## Files Changed
+- `automaton/dashboard/core/task.py`: Added `_state_string_to_task_state()` function, modified `determine_task_state()` to read `.state` before falling back to artifact heuristic
+
+## Tests
+- Existing tests in `test_task.py` continue to pass (they test the artifact fallback path since test tasks don't have `.state` files by default)
+- All 249 tests pass
@@ -0,0 +1,16 @@
+# Spec: fix-dashboard-read-state
+
+## Problem
+`automaton/dashboard/core/task.py:462` (`determine_task_state`) infers task phase purely from artifact files, never reading the `.state` file. This contradicts `prompts/workflow.md` which declares `.state` as the "single source of truth." The dashboard cannot reflect the actual enforced state.
+
+## Fix
+Read the `.state` file first in `determine_task_state()`. If `.state` exists, parse the phase and map it to a `TaskState`. Fall back to artifact heuristics only if `.state` doesn't exist (pre-v2.0 tasks).
+
+The phase string in `.state` may include substates like `research:awaiting_approval` — map these to their base phase (`research`).
+
+## Acceptance Criteria
+- A task in `implement` phase (per `.state`) shows as `IMPLEMENT` in the dashboard even without IMPLEMENTATION.md
+- A task in `test_design` phase shows as `TEST_DESIGN`, not `IMPLEMENT`
+- A task without `.state` still uses artifact heuristics (backward compat)
+- Existing dashboard tests in `test_task.py` still pass
+- Add test verifying `.state` takes precedence over artifacts
@@ -0,0 +1,13 @@
+# Verdict: fix-dashboard-read-state
+
+## Status: PASS
+
+## Summary
+Fixed dashboard `determine_task_state()` to read `.state` file (source of truth) before falling back to artifact heuristic. Added `_state_string_to_task_state()` for proper phase string to enum mapping, including sub-state handling.
+
+## Artifacts
+- IMPLEMENTATION.md: Complete
+- CODE_REVIEW.md: PASS
+- BUG_REPORT.md: No bugs found
+- ADVERSARIAL_BUG_REPORT.md: No bugs found
+- DOC_REVIEW.md: PASS