Add code_review phase with approval gate, reviewer≠implementer enforcement, and structured CODE_REVIEW.md
CI / build (push) Has been cancelled
CI / build (push) Has been cancelled
- Insert code_review phase between implement and bug_find - Approval gate: code_review:awaiting_approval → code_review:approved - Read-only phase — no edits, no fixes, no returning to implement - Reviewer≠implementer: .state.implementer tracking + --claim enforcement - Structured CODE_REVIEW.md: spec compliance, design conformance, quality scorecard, items found (severity/category/location/resolution), test coverage - Updated status.py (10 data structures), dashboard (4 files), prompts (3 files), agent routing, tests (6 new test classes, 19 new tests)
This commit is contained in:
@@ -43,7 +43,7 @@ Never piggyback on a stale task — create a new one for new work.
|
||||
The full state machine is defined in ~/.automaton/prompts/workflow.md. Key points:
|
||||
|
||||
- **`.state` file is the single source of truth** — always read `.state` first, fall back to artifact heuristic if missing
|
||||
- **Approval gates**: research, decomposition, design, and test_design require `:awaiting_approval` → `:approved` before proceeding
|
||||
- **Approval gates**: research, decomposition, design, test_design, and code_review require `:awaiting_approval` → `:approved` before proceeding
|
||||
- **Transitions**: All transitions go through `python ~/.automaton/scripts/status.py --transition {phase} --task {task-name} --project {project}`
|
||||
- **Approvals**: All approvals go through `python ~/.automaton/scripts/status.py --approve --task {task-name} --project {project}`
|
||||
- **Task creation**: Always use `python ~/.automaton/scripts/status.py --create-task {name} --project {project}`
|
||||
@@ -59,7 +59,7 @@ For each phase in autopilot:
|
||||
3. If violations found → STOP and report (phase-skipping detected)
|
||||
4. Load phase prompt → confirm ALLOWED/FORBIDDEN boundaries
|
||||
5. Execute phase → produce required artifact
|
||||
6. If phase requires approval (research, decomposition, design, test_design):
|
||||
6. If phase requires approval (research, decomposition, design, test_design, code_review):
|
||||
a. Run: python ~/.automaton/scripts/status.py --transition {phase}:awaiting_approval --task {task-name} --project {project}
|
||||
b. STOP and wait for user to say "APPROVED"
|
||||
c. Run: python ~/.automaton/scripts/status.py --approve --task {task-name} --project {project}
|
||||
@@ -134,7 +134,7 @@ During long autopilot runs, call `python ~/.automaton/scripts/status.py --audit
|
||||
## Rules
|
||||
|
||||
1. **Never skip a phase** — all transitions must go through `status.py --transition`
|
||||
2. **Wait for approval** — research, decomposition, design, and test_design require `:awaiting_approval` → `:approved`
|
||||
2. **Wait for approval** — research, decomposition, design, test_design, and code_review require `:awaiting_approval` → `:approved`
|
||||
3. **Validate before proceeding** — run `status.py --validate-folder --project {project}` before each phase
|
||||
4. **Never create tasks manually** — always use `status.py --create-task`
|
||||
5. **Always pass `--project {project}`** — ensures correct scoping when working on multiple projects
|
||||
|
||||
Reference in New Issue
Block a user