21 lines
834 B
Markdown
21 lines
834 B
Markdown
|
# Adversarial Bug Report: hook-install-process
|
||
|
|
|
||
|
|
## Summary
|
||
|
|
No critical issues. Two minor observations.
|
||
|
|
|
||
|
|
## Bugs Found
|
||
|
|
|
||
|
|
### Bug 1: upgrade.sh doesn't verify python3 is available (Low)
|
||
|
|
- **Severity**: Low
|
||
|
|
- **Location**: scripts/upgrade.sh line 26
|
||
|
|
- **Description**: The script runs `python3 "$STATUS_SCRIPT" --upgrade` without checking if python3 exists. If python3 is not on PATH, the upgrade silently fails (due to `|| true`).
|
||
|
|
- **Suggested Fix**: Add a python3 availability check at the start.
|
||
|
|
|
||
|
|
### Bug 2: Pre-commit hook doesn't handle bare repos (Low)
|
||
|
|
- **Severity**: Low
|
||
|
|
- **Location**: scripts/git-hooks/pre-commit
|
||
|
|
- **Description**: If the project uses a bare repo or worktrees, `.git/hooks/` may not exist at the expected path.
|
||
|
|
- **Suggested Fix**: Use `git rev-parse --git-dir` instead of assuming `.git/hooks/`.
|
||
|
|
|
||
|
|
## Score
|
||
|
|
+5
|