14 lines
956 B
Markdown
14 lines
956 B
Markdown
|
# Code Review: fix-verdict-pass-inference
|
||
|
|
|
||
|
|
## Summary
|
||
|
|
Replaces fragile substring search with structured-line parsing, matching the dashboard's existing `parse_verdict_status()` approach.
|
||
|
|
|
||
|
|
## Findings
|
||
|
|
- **Correctness**: `_parse_verdict_status_line()` correctly looks for `## Status:` and `- **Status**:` headers, extracting the value after the colon. The `after_colon.upper()` comparison handles case variations.
|
||
|
|
- **Consistency**: The new helper mirrors `automaton/dashboard/core/task.py:parse_verdict_status()` — good alignment between enforcement layers.
|
||
|
|
- **Fallback**: Unparseable verdicts now return `"human_intervention"` instead of the old behavior (which would have returned `human_intervention` for anything without "PASS"). This is a safe default.
|
||
|
|
- **Edge case**: A verdict with `## Status: PASS` and "FAIL" in body correctly returns `complete` — the structured parse only looks at the status line.
|
||
|
|
|
||
|
|
## Verdict
|
||
|
|
APPROVED — no issues found.
|