57 lines
2.6 KiB
Markdown
57 lines
2.6 KiB
Markdown
|
# CODE_REVIEW: add-self-improvement-loop
|
||
|
|
|
||
|
|
## Reviewed Files
|
||
|
|
|
||
|
|
1. `scripts/install.sh` -- self-improvement loop bootstrap (lines ~70-82)
|
||
|
|
2. `scripts/update.sh` -- idempotent loop bootstrap (lines ~61-70)
|
||
|
|
3. `tests/test_self_improvement_loop.py` -- 16 tests
|
||
|
|
4. `CHANGELOG.md` -- task 7 entry
|
||
|
|
5. `design/loops/technical.md` section 9 -- updated install note
|
||
|
|
6. `README.md` -- self-improvement loop default-on section
|
||
|
|
|
||
|
|
## Findings
|
||
|
|
|
||
|
|
### 1. install.sh -- loop bootstrap placement
|
||
|
|
|
||
|
|
The loop bootstrap is placed inside the `else` block (after the git clone), after guard registration and before `fi`. This is correct -- the loop should only be created on fresh installs, not when the framework is already installed (the `if [ -d "$FRAMEWORK_DIR" ]` branch prints "already installed" and exits).
|
||
|
|
|
||
|
|
The `|| true` ensures install continues even if `status.py` fails (e.g. Python not in PATH yet, or schedule installation fails on an unusual platform). The framework works without the loop.
|
||
|
|
|
||
|
|
**Verdict:** PASS
|
||
|
|
|
||
|
|
### 2. update.sh -- idempotent bootstrap
|
||
|
|
|
||
|
|
The `if [ ! -d "$FRAMEWORK_DIR/loops/self-improvement" ]` check correctly prevents duplicate creation. `--create-loop` itself also refuses duplicates (returns rc=2), but the directory check avoids the error output entirely. The `|| true` on both commands ensures update continues on failure.
|
||
|
|
|
||
|
|
**Verdict:** PASS
|
||
|
|
|
||
|
|
### 3. Test coverage
|
||
|
|
|
||
|
|
- `TestInstallShWiring` (5 tests): covers create-loop, install-schedule, opt-out message, framework project, and non-fatal behavior. All assertions check the script content.
|
||
|
|
- `TestUpdateShWiring` (4 tests): covers create-loop, idempotent check, install-schedule, and non-fatal behavior.
|
||
|
|
- `TestSelfImprovementTemplate` (5 tests): regression guard for template fields.
|
||
|
|
- `TestCreateLoopFromTemplate` (2 tests): integration test for `cmd_create_loop` with the self-improvement template.
|
||
|
|
|
||
|
|
**Verdict:** PASS
|
||
|
|
|
||
|
|
### 4. Shell syntax
|
||
|
|
|
||
|
|
`bash -n scripts/install.sh scripts/update.sh` passes. No syntax errors.
|
||
|
|
|
||
|
|
**Verdict:** PASS
|
||
|
|
|
||
|
|
### 5. Edge cases
|
||
|
|
|
||
|
|
- **Python not in PATH**: `|| true` handles this. Install continues.
|
||
|
|
- **Loop already exists (update.sh)**: directory check prevents creation; `--create-loop` also refuses.
|
||
|
|
- **Schedule installation fails**: `|| true` handles this. Loop is created but not scheduled; user can manually `--install-schedule` later.
|
||
|
|
- **Framework not in ~/.automaton**: the `$FRAMEWORK_DIR` variable is set at the top of each script and used consistently.
|
||
|
|
|
||
|
|
**Verdict:** PASS
|
||
|
|
|
||
|
|
## Summary
|
||
|
|
|
||
|
|
All 5 review areas pass. The implementation is clean, idempotent, and well-tested. 16 new tests cover script wiring, template validation, and loop creation. Full suite: 409 passed.
|
||
|
|
|
||
|
|
**Overall verdict: APPROVED**
|