17 lines
719 B
Markdown
17 lines
719 B
Markdown
# Code Review: linux-schedule-parity
|
|||
|
|
|
||
|
|
## Files reviewed
|
||
|
|
- `scripts/status.py` — `_install_cron_block`, `_enable_schedule`, `_disable_schedule`
|
||
|
|
- `tests/test_linux_schedule_parity.py` — 13 tests
|
||
|
|
|
||
|
|
## Summary
|
||
|
|
All implementation requirements met:
|
||
|
|
1. `_install_cron_block` writes cron block atomically, strips prior blocks, rounds interval to nearest minute (min 1)
|
||
|
|
2. `_enable_schedule` dispatches per platform (Linux=cron, Darwin=plist, Windows=nop); reads interval from `loop.json`; handles missing stub gracefully
|
||
|
|
3. `_disable_schedule` strips cron blocks back out
|
||
|
|
4. 13/13 tests pass with full coverage of normal paths, error paths, and edge cases
|
||
|
|
5. No new dependencies, no breaking changes
|
||
|
|
|
||
|
|
## Issues
|
||
|
|
None found.
|