23 lines
1.4 KiB
Markdown
23 lines
1.4 KiB
Markdown
|
# Code Review: fix-stale-task-mtime-proxy
|
||
|
|
|
||
|
|
## Reviewed Files
|
||
|
|
- `scripts/status.py` (`_get_edit_timestamp()`, `_touch_lastedit()`, `cmd_can_edit()`, `cmd_same_session()`, `cmd_touch()`, `NON_ARTIFACT_FILES`)
|
||
|
|
|
||
|
|
## Changes
|
||
|
|
1. Added `.state.lastedit` file as the stale-task timer source
|
||
|
|
2. `_touch_lastedit()` called on ALLOWED `--can-edit` responses
|
||
|
|
3. `_get_edit_timestamp()` reads `.state.lastedit` with fallback to `.state` mtime
|
||
|
|
4. Added staleness check to single-task `--can-edit --task` path
|
||
|
|
5. `--touch` now touches `.state.lastedit` instead of `.state`
|
||
|
|
|
||
|
|
## Analysis
|
||
|
|
- **Correctness**: Using `.state.lastedit` (touched on actual edit activity) is a better proxy for staleness than `.state` mtime (which only reflects phase transitions)
|
||
|
|
- **Backward compatibility**: Falls back to `.state` mtime when `.state.lastedit` doesn't exist
|
||
|
|
- **Non-artifact**: `.state.lastedit` correctly added to `NON_ARTIFACT_FILES` to avoid being treated as a phase artifact
|
||
|
|
- **Single-task path**: Adding staleness check to `--can-edit --task` makes enforcement consistent across both code paths
|
||
|
|
- **`--touch` command**: Updated to touch `.state.lastedit` — consistent with the new activity tracking model
|
||
|
|
|
||
|
|
## Verdict: PASS
|
||
|
|
|
||
|
|
The fix is well-structured, maintains backward compatibility, and correctly addresses the mtime proxy issue. Tests cover creation, staleness detection, and fallback behavior.
|